fix(ios): Correct layout validity status during layout changed event#11218
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 48befa9
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On iOS, the
isLayoutValidgetter can be true when checked in alayoutChangedevent listener.This causes platform inconsistency and reports a valid layout before computations are over.
What is the new behavior?
Updated the getter to reflect the android approach since the core layout system for iOS is inspired from it and added an automated test to cover the case explained.
This is helpful for plugins to make use of that flag and have identical results for both platforms.
Additionally, causing the flag to be truthy at a later point makes it wait for
layoutIfNeededcall, thus making it usable for tests that didn't pass till now.