feat(observable): enhance event callback type specificity#10720
Merged
nativescript-oss merged 2 commits intoMar 16, 2025
Merged
Conversation
NathanWalker
added a commit
that referenced
this pull request
Mar 16, 2025
CatchABus
pushed a commit
to CatchABus/NativeScript
that referenced
this pull request
Jun 28, 2025
…ativeScript#10721) Revert "feat(observable): enhance event callback type specificity (NativeScript#10720)" This reverts commit e2f9687.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, the
on,off, andoncemethods in@nativescript/core/data/observable/index.tsuse a genericEventDatatype for all event callbacks, regardless of the event name. This lacks type specificity, especially for "Change" events, which should usePropertyChangeData.What is the new behavior?
This PR introduces the
EndsWithutility type to dynamically determine the callback data type based on the event name. If theeventNameends with "Change", the callback will usePropertyChangeData; otherwise, it will useEventData. This provides improved type safety and developer experience.