Skip to content

feat(types-ios): latest 18.x types #10629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 7 commits into from
Nov 2, 2024
Merged

feat(types-ios): latest 18.x types #10629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7598eb6
chore: nx migrate latest
NathanWalker Sep 26, 2024
247bc71
feat(types-ios): latest 18.x types
NathanWalker Sep 26, 2024
8eb752d
Merge remote-tracking branch 'origin/main' into feat/ios-typings-updates
NathanWalker Nov 2, 2024
cdebee2
chore: cleanup deps
NathanWalker Nov 2, 2024
40310fe
feat: 18.1 sdk
NathanWalker Nov 2, 2024
fa221a8
chore: cleanup
NathanWalker Nov 2, 2024
76f3a02
chore: cleanup
NathanWalker Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/automated/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@
},
"configurations": {}
},
"clean": {
"executor": "@nativescript/nx:clean",
"options": {}
},
"lint": {
"executor": "@nx/eslint:lint",
"options": {
Expand Down
4 changes: 2 additions & 2 deletions apps/automated/src/ui/layouts/safe-area-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class SafeAreaTests extends testModule.UITest<any> {

const view: UIView = layout.page.actionBar.nativeViewProtected;
// use the action bar position and size instead of the status bar and action bar heights as those are unreliable on iOS 16+
const topInset = round(dipToDp(view.frame.origin.y + view.frame.size.height));
const topInset = Math.round(dipToDp(view.frame.origin.y + view.frame.size.height));

const insets = layout.getSafeAreaInsets();
equal(insets.top, topInset, `${layout}.topInset - actual:${insets.top}; expected: ${topInset}`);
Expand All @@ -87,7 +87,7 @@ export class SafeAreaTests extends testModule.UITest<any> {
const keyWindow = Utils.ios.getWindow();
// const statusBarHeight = round(dipToDp(app.statusBarFrame.size.height));
// use window inset instead of status bar frame as that's unreliable on iOS 16+
const topInset = round(dipToDp(keyWindow ? keyWindow.safeAreaInsets.top : UIApplication.sharedApplication.keyWindow.safeAreaInsets.top));
const topInset = Math.round(dipToDp(keyWindow ? keyWindow.safeAreaInsets.top : UIApplication.sharedApplication.keyWindow.safeAreaInsets.top));

const insets = layout.getSafeAreaInsets();
equal(insets.top, topInset, `${layout}.topInset - actual:${insets.top}; expected: ${topInset}`);
Expand Down
10 changes: 5 additions & 5 deletions apps/automated/src/ui/scroll-view/scroll-view-safe-area-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ScrollLayoutSafeAreaTest extends UITest<ScrollView> {
waitUntilTestElementLayoutIsValid(ui.root);
test(ui);
},
pageOptions
pageOptions,
);
}

Expand Down Expand Up @@ -70,7 +70,7 @@ class ScrollLayoutSafeAreaTest extends UITest<ScrollView> {
({ root }) => {
this.scroll_view_in_full_screen(root, pageOptions);
},
pageOptions
pageOptions,
);
}

Expand Down Expand Up @@ -194,11 +194,11 @@ class ScrollLayoutSafeAreaTest extends UITest<ScrollView> {
isBelowWith(root, childFirst, insets.top);
isRightWith(childFirst, root, insets.right);

const scrollViewContentHeight = round(dipToDp(root.nativeViewProtected.contentSize.height));
const scrollViewContentHeight = Math.round(dipToDp(root.nativeViewProtected.contentSize.height));
const sumOfNestedLabelHeightsAndInsets = height(childFirst) * stack.getChildrenCount() + insets.top + insets.bottom;
equal(scrollViewContentHeight, sumOfNestedLabelHeightsAndInsets, `scroll view content height<${scrollViewContentHeight}> sum of nested label height and insets <${sumOfNestedLabelHeightsAndInsets}>`);
},
pageOptions
pageOptions,
);
}

Expand Down Expand Up @@ -426,7 +426,7 @@ class ScrollLayoutSafeAreaTest extends UITest<ScrollView> {
const sumOfNestedScrollViewWidths = width(cells[1][0]) + width(cells[1][1]) + width(cells[1][2]);
equal(width(grid), sumOfNestedScrollViewWidths, `grid width<${width(grid)}> sum of nested scroll views width <${sumOfNestedScrollViewWidths}>`);
},
pageOptions
pageOptions,
);
}

Expand Down
2 changes: 1 addition & 1 deletion apps/toolbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"@nativescript/core": "file:../../packages/core",
"@nativescript/imagepicker": "^3.2.1",
"@nativescript/imagepicker": "^4.1.0",
"nativescript-theme-core": "file:../../node_modules/nativescript-theme-core"
},
"devDependencies": {
Expand Down
4 changes: 4 additions & 0 deletions apps/toolbox/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@
},
"configurations": {}
},
"clean": {
"executor": "@nativescript/nx:clean",
"options": {}
},
"lint": {
"executor": "@nx/eslint:lint",
"options": {
Expand Down
Loading