fix(application): wrap native classes in initialisers#10335

Merged

rigor789 merged 1 commit intomainfrom

fix/application-native-classes

Jul 10, 2023

Member

rigor789 commented Jul 6, 2023

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

new native classes are attempted to be initialised in workers, causing workers to crash.

What is the new behavior?

native classes are initialised once on the main app thread and reused as necessary in workers.

fixes: #10334


          fix(application): wrap native classes in initialisers

46d6cd1

fixes: #10334

cla-bot bot added the cla: yes label

rigor789 marked this pull request as ready for review

July 6, 2023 14:56

rigor789 merged commit 5359153 into main

rigor789 deleted the fix/application-native-classes branch

July 10, 2023 07:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels