test: standardized unit testing with jest#10047
Merged
Merged
Conversation
e093c4d to
2e64809
Compare
3e21499 to
1618c7b
Compare
rigor789
reviewed
Nov 27, 2022
Member
rigor789
left a comment
There was a problem hiding this comment.
Looks great, noted a few questions here&there...
| }, | ||
| extensionsToTreatAsEsm: ['.ts'], | ||
| moduleDirectories: ['node_modules'], | ||
| moduleFileExtensions: ['ts', 'js', 'ios.ts'], |
Member
There was a problem hiding this comment.
Wonder if we could run the whole test-suite twice, once against .ios.ts and once against .android.ts to cover all files...
Contributor
Author
There was a problem hiding this comment.
Thanks for mentioning yes I am wanting to do this. Was considering two different configs and .spec.json that could be run independently for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Unit tests were awkward to work with and maintain.
What is the new behavior?
Unit tests are now easy to work with, use and maintain.