If an Animation instance is played more than once, the same promise is resolved each time leading to unexpected results. #774

Activity

1. hamorphis

   added

   severity: high

   bug

   on Sep 18, 2015
2. hamorphis

   self-assigned this

   on Sep 18, 2015
3. hamorphis

   added this to the 1.4.0 milestone on Sep 18, 2015
4. hamorphis

   added a commit that references this issue on Sep 21, 2015

   Removed a code snippet until Issue #774 is fixed.

   ...

   8483124
5. hamorphis commented on Sep 21, 2015

   

   hamorphis

   on Sep 21, 2015

   ContributorAuthor

   More actions

   Breaking changes

   • (#774) Animation class no longer has a finished property because an animation can be played multiple times. The play method now returns a new Promise each time it is invoked. Use this to listen for the animation finishing or being cancelled. When upgrading to version 1.4.0 or above simply remove .finished from your code.

   Old Code (JavaScript):

   animation1.play().finished.then(function () { console.log("Finished"); });

   New Code (JavaScript):

   animation1.play().then(function () { console.log("Finished"); });

   Old Code (TypeScript):

   animation1.play().finished.then(()=>console.log("Finished"));

   New Code (JavaScript):

   animation1.play().then(()=>console.log("Finished"));
6. hamorphis

   added a commit that references this issue on Sep 21, 2015

   Fixed: If an Animation instance is played more than once, the same pr…

   ...

   beef7f9
7. hamorphis

   added

   in progress

   on Sep 21, 2015
8. hamorphis

   closed this as completedon Sep 21, 2015
9. hamorphis

   added

   done

   and removed

   in progress

   on Sep 21, 2015
10. lock commented on Aug 30, 2019

    

    lockbot

    on Aug 30, 2019

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
11. lock

    locked and limited conversation to collaborators on Aug 30, 2019