Skip to content

Allow ActionItems to be directly specified between the ActionBar opening and closing tags. #518

Closed

Description

@PanayotCankov

The silly me put this on a page:

  <Page.actionBar>
    <ActionBar>
      <ActionItem text="{{ resources.signUp }}" tap="signUpMenuItemTap" android.position="actionBar" />
    </ActionBar>
  </Page.actionBar>

At runtime it works like a charm. The only problem is the action item does not appear.

Obviously the correct usage is:

  <Page.actionBar>
    <ActionBar>
      <ActionBar.actionItems>
        <ActionItem text="{{ resources.signUp }}" tap="signUpMenuItemTap" android.position="actionBar" />
      </ActionBar.actionItems>
    </ActionBar>
  </Page.actionBar>

The problem is the first case does not generate neither compile-time nor run-time error.

Activity

  1. ligaz commented on Jul 31, 2015

    @ligaz
    Contributor

    See here for a possible solution.

  2. PanayotCankov commented on Aug 3, 2015

    @PanayotCankov
    ContributorAuthor

    I would agree to have both decorators marking the content properties and errors/warnings. However when you look at the issues - the snippets are identical but the problems are different.

  3. enchev commented on Oct 16, 2015

    @enchev
    Contributor

    Merged with this: #597

  4. added this to the milestone on Nov 27, 2015
  5. self-assigned this
    on Dec 16, 2015
  6. changed the title [-]Better XML declaration error reporting for unacceptable content[/-] [+]Allow ActionItems to be specified directly between the ActionBar opening and closing tags.[/+] on Dec 16, 2015
  7. changed the title [-]Allow ActionItems to be specified directly between the ActionBar opening and closing tags.[/-] [+]Allow ActionItems to be directly specified between the ActionBar opening and closing tags.[/+] on Dec 16, 2015
  8. added 2 commits that reference this issue on Dec 16, 2015
  9. lock commented on Aug 30, 2019

    @lock

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  10. locked and limited conversation to collaborators on Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions