Skip to content

ScrollView base: Adding listener when you are supposed to remove it #4993

Closed
Closed
ScrollView base: Adding listener when you are supposed to remove it#4993
Labels
backlogbug
Milestone
3.4

Description

@alg
alg
opened on Oct 27, 2017

Have a look here:

NativeScript/tns-core-modules/ui/scroll-view/scroll-view-common.ts

Lines 23 to 24 in b192abf

public removeEventListener(arg: string, callback: any, thisArg?: any) {
super.addEventListener(arg, callback, thisArg);

Is it really correct that you add listener when you are supposed to remove it?

Activity

  1. NickIliev
    added
    bug
    on Oct 27, 2017

  2. NickIliev commented on Oct 27, 2017

    @NickIliev
    NickIliev
    on Oct 27, 2017
    Contributor

    @alg Nice catch! The issue will be resolved via this PR

  3. NickIliev
    added
    backlog
    in progress
    ready for testTSC needs to test this and confirm against live production apps and automated test suites
    on Oct 27, 2017
  4. NickIliev
    added this to the milestone on Oct 27, 2017
  5. tsonevn
    closed this as completedon Nov 28, 2017
  6. tsonevn
    removed
    ready for testTSC needs to test this and confirm against live production apps and automated test suites
    on Nov 28, 2017
  7. SvetoslavTsenov
    removed
    in progress
    on Dec 20, 2017

  8. lock commented on Aug 27, 2019

    @lock
    lockbot
    on Aug 27, 2019

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  9. lock
    locked and limited conversation to collaborators on Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogbug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions