Repository navigation
Question: Core Module change causing style to break #4728
Description
Please, provide the details below:
I normally wouldn't open an issue for this type of bug without investigating but too many people have hit the same issue and I don't recall any changes in the plugins in quite some time and I haven't had time to debug the issue. The issue is on both cardview and floatingactionbutton plugin repos have been opened with the same issue recently.
nstudio/nativescript-cardview#64
nstudio/nativescript-floatingactionbutton#57
Which platform(s) does your issue occur on?
Android for sure
Please provide the following version numbers that your issue occurs with:
See issue
Please tell us how to recreate the issue in as much detail as possible.
Run latest core modules with either the cardview or fab plugin as described in the issue on the repos. Someone has reported a revert in the core-modules fixed the issue and then when updating to the latest it breaks again.
Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.
Demo code on repos should be sufficient.
Activity
tsonevn commentedon Aug 23, 2017
Hi @bradmartin,
Thank you for reporting this issue.
We reviewed the described scenario and indeed there is an issue with getting drawable from the native view, which in some cases is a null object.
We will investigate further how to resolve this problem and will provide a fix inside the
tns-core-modules.Regards,
@tsonevn
hshristov commentedon Aug 29, 2017
Hi @bradmartin
Thanks for reporting this. It is fixed in the master branch with this PR: #4742 and will be live in 3.2
SP1966 commentedon Sep 11, 2017
After updating this issue is still unresolved in both of the following plugins:
nstudio/nativescript-floatingactionbutton#57
nstudio/nativescript-cardview#64
jafsparrow commentedon Sep 25, 2017
Hi All,
Any update on this? anybody figured out the reason and way to fix it.?
bradmartin commentedon Sep 25, 2017
@hshristov - I believe an issue might still be present on Android 6 per this comment nstudio/nativescript-floatingactionbutton#57 (comment)
jafsparrow commentedon Sep 25, 2017
Thanks Brad, I will try this on 7 then..!
But there's gotta be a reason for this..! I'm facing same kind of issue with FAB and CardView.
Fix crash on API 23 where constantState.newDrawable(nativeView.getRes…
hshristov commentedon Oct 18, 2017
@bradmartin @jafsparrow @SP1966
Addition to the original fix because of bug in Android 6.0 API 23
#4959
Fix crash on API 23 where constantState.newDrawable(nativeView.getRes…
jafsparrow commentedon Oct 18, 2017
Thank you @hshristov.
for FAB and CardView
I think explicitly giving the color property is solving the issue (can be used a hack fix).
I was also testing the dropdown plugin which is also breaking if some properties are not given in css (specifying the properties in css fixes the issue).
thanks guys for your helps..
lock commentedon Aug 27, 2019
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.