Skip to content

iOS ActionBar will be broken when internet sharing bar is displayed #4283

Open

Description

@kssfilo

Which platform(s) does your issue occur on?

iOS

Please provide the following version numbers that your issue occurs with:

CLI: 3.0.0
Cross-platform modules: 3.0.0
Runtime(s): 3.0.1
Plugin(s): -

Please tell us how to recreate the issue in as much detail as possible.

  1. Deploy test app which enabled ActionBar into a real iPhone device
  2. Turn internet sharing on by iOS settings screen
  3. Connect other device to this iPhone(Tethering) to show blue "Internet sharing bar" on top of screen.
  4. back to the test app

-> Action Bar is broken


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Activity

  1. tsonevn commented on May 29, 2017

    @tsonevn
    Contributor

    Hi @kssfilo,
    I reviewed your case and need the ActionBar element will not be shown properly, while the sharing bar has been displayed. We will research this problem and will provide the needed fix.
    I am also attaching an image of the device, where the problem could be seen.
    img_0158

  2. changed the title [-][TNS3.0] iOS ActionBar will be broken when internet sharing bar is displayed[/-] [+]iOS ActionBar will be broken when internet sharing bar is displayed[/+] on May 29, 2017
  3. jilenloa commented on Jun 21, 2017

    @jilenloa

    hi, is there any solution or workaround for this yet?

  4. KBorecki commented on Jun 22, 2017

    @KBorecki

    Hi, the same here. this is annoying issue :(

  5. tsonevn commented on Jun 23, 2017

    @tsonevn
    Contributor

    Hi @jilenloa @KBorecki,
    At this time this issue is still under review and there is no workaround which could be used. Most probably this behavior is related to an issue with the iOS constraints, while the bar is shown.

  6. kssfilo commented on Jun 23, 2017

    @kssfilo
    ContributorAuthor

    @jilenloa @KBorecki @tsonevn

    I have found workaround like below and sent PR. You can try to edit frame.ios.js in node_modules/tns-core-modules/ui/frame/ then test it by your application (with internet sharing or Alt+y on emulator).

    (DP->DIP is not necessary if src is this._ios.controller.navigationBar.frame)

    --- tns-core-modules/ui/frame/frame.ios.js.org	2017-06-23 22:39:55.000000000 +0900
    +++ tns-core-modules/ui/frame/frame.ios.js	2017-06-23 22:40:19.000000000 +0900
    @@ -306,7 +306,7 @@
             }
             this._ios.controller.navigationBar.autoresizingMask = 0;
             this._ios.controller.navigationBar.removeConstraints(this._ios.controller.navigationBar.constraints);
    -        this._ios.controller.navigationBar.frame = CGRectMake(utils.layout.toDeviceIndependentPixels(this._ios.controller.navigationBar.frame.origin.x), utils.layout.toDeviceIndependentPixels(statusBarHeight), utils.layout.toDeviceIndependentPixels(this._ios.controller.navigationBar.frame.size.width), utils.layout.toDeviceIndependentPixels(this._ios.controller.navigationBar.frame.size.height));
    +        this._ios.controller.navigationBar.frame = CGRectMake(this._ios.controller.navigationBar.frame.origin.x, utils.layout.toDeviceIndependentPixels(statusBarHeight), this._ios.controller.navigationBar.frame.size.width, this._ios.controller.navigationBar.frame.size.height);
         };
         return Frame;
     }(frame_common_1.FrameBase));
    
  7. Pinny3 commented on Jun 26, 2017

    @Pinny3

    When is this issue going to be fixed? We need it.... :-)

  8. added this to the milestone on Jun 28, 2017
  9. 2 remaining items

  10. added and removed
    ready for testTSC needs to test this and confirm against live production apps and automated test suites
    on Jun 28, 2017
  11. SvetoslavTsenov commented on Jun 28, 2017

    @SvetoslavTsenov
    Contributor

    Thanks to @kssfilo the fix is already available with tns-core-modules@next and will be released officially with tns-core-modules@3.2.0.

  12. SvetoslavTsenov commented on Oct 20, 2017

    @SvetoslavTsenov
    Contributor

    Hey, I am reopening this issue because I reproduce it on iOS 11 again.
    image

  13. modified the milestones: 3.1.1, 4.3 (TBD) on Jul 27, 2018
  14. modified the milestones: 5.0, 5.1 (TBD) on Oct 4, 2018
  15. removed this from the 5.1 milestone on Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions