Activity

1. m-abs commented on Sep 26, 2016

   

   m-abs

   on Sep 26, 2016

   ContributorAuthor

   More actions

   Update:

   I think I see the problem:
   https://github.com/NativeScript/NativeScript/blob/2.3.0/tns-core-modules/ui/action-bar/action-bar.ios.ts#L134-L163

   If we have an icon on the ActionItem the text is never set on the UIBarButtonItem, so of cause iOS' VoiceOver can't read the text.

   I'm working on a PR that hopefully solves the problem.
2. m-abs

   added a commit that references this issue on Sep 26, 2016

   fix: NativeScript#2796 - ActionItems lacks proper support for VoiceOv…

   ...

   This issue will close once commit ded170e is merged into the 'master' branch.

   ded170e
3. tsonevn

   added

   feature

   on Sep 26, 2016
4. vchimev commented on Sep 29, 2016

   

   vchimev

   on Sep 29, 2016

   Contributor

   More actions

   Hi @m-abs,

   Thank you for the pull request.

   Could you please send us a sample page which demonstrates the issue along with:

   • how does VoiceOver read it currently and
   • how is it expected to read it?

   In this way, we would be able to review your pull request properly.

   For example, my test page is as follow:

   <Page>
     <Page.actionBar>
       <ActionBar >
         <ActionBar.actionItems>
           <ActionItem text="Item" />
           <ActionItem>
             <ActionItem.actionView>
               <Button text="View" automationText="test" />
             </ActionItem.actionView>
           </ActionItem>
         </ActionBar.actionItems>
       </ActionBar>
     </Page.actionBar>
     <StackLayout>
       <Label text="This is a test."/>
     </StackLayout>
   </Page>
   

   It is read as follows: Item -> Button, Test -> Button
5. m-abs commented on Oct 1, 2016

   

   m-abs

   on Oct 1, 2016

   Last edited by m-abs

   ContributorAuthor

   More actions

   HI @vchimev,

   The problem is caused by adding an icon to the ActionItem, because the text-value was never added to the UINavigationButton.

   I've written a demo as requested, it's based on tns create APP_NAME --template typescript and I've tested with a local install of ´tns-core-moduleswith my patch and ontns-core-modules@next`

   The screenshots is from running on the iPhone emulator, so you can see the Accessibility Inspector:

   The ActionItem on https://github.com/m-abs/actionitem-demo/blob/master/app/main-page.xml#L5

   Here without my patch:
   
   As you can see the inspector says the Label is X the filename of my icon.

   Expected reading order is "My ActionItem Text" -> "Button"
   As seen here with the patch:
   

   If you were testing the ActionItem > Button on tns-core-modules@2.3.0, my other PR for automationText on iOS weren't a part of that release. (#2678) but it is on master, so it's in my current PR.

   Expected reading order "AutoText" > "Button"
   As seen here:
   

   Note: that automationText doesn't exist on ActionItem because contentDescription doesn't exist on the MenuItem used on Android.
6. vchimev commented on Oct 4, 2016

   

   vchimev

   on Oct 4, 2016

   Contributor

   More actions

   @m-abs, many thanks for the details.
7. hshristov

   closed this as completedin #2799on Oct 5, 2016
8. hshristov

   added a commit that references this issue on Oct 5, 2016

   fix: #2796 - ActionItems lacks proper support for VoiceOver on iOS (#…

   ...

   This issue will close once commit 37d927b is merged into the 'main' branch.

   37d927b
9. vchimev

   added this to the 2.4.0 milestone on Oct 5, 2016
10. lock commented on Aug 29, 2019

    

    lockbot

    on Aug 29, 2019

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
11. lock

    locked and limited conversation to collaborators on Aug 29, 2019