Skip to content

Feature Request: Improved ActionBar CSS Support #2740

Closed

Description

@firescript

In order to take out the action bar shadow you must use js, here is the code to do it.

    if (page.ios) {
        navigationBar.shadowImage = new UIImage();
        navigationBar.setBackgroundImageForBarMetrics(new UIImage(), UIBarMetrics.UIBarMetricsDefault)
    }   

I think it would make sense to make use of the border css property to over ride that. Setting border: 0; on an ActionBar, should remove that naturally.

The other thing is I cant seem to set the actionbar to transparent/transulcent? background-color:transparent; or background-color: rgba(0,0,0,.8) would make sense, in combination with the removal of the shadow on the action bar, it would give me a clean, transparent/transulcent actionbar.

Activity

  1. changed the title [-]Be able to style out ActionBar Shadow with CSS[/-] [+]Feature Request: Improved ActionBar Support[/+] on Sep 16, 2016
  2. changed the title [-]Feature Request: Improved ActionBar Support[/-] [+]Feature Request: Improved ActionBar CSS Support[/+] on Sep 16, 2016
  3. sitefinitysteve commented on Sep 16, 2016

    @sitefinitysteve
    Contributor

    +1 for "transparent"

  4. wnas commented on Oct 31, 2016

    @wnas

    +1 for border 0 in css.

  5. pmz commented on Nov 1, 2016

    @pmz

    +1. This is bugging me :)

  6. added a commit that references this issue on Mar 29, 2017
  7. EddyVerbruggen commented on Mar 29, 2017

    @EddyVerbruggen
    Contributor

    Please join the discussion at #3900, thanks!

  8. modified the milestone: 3.1.1 on Jul 28, 2017
  9. added
    ready for testTSC needs to test this and confirm against live production apps and automated test suites
    and removed on Jul 28, 2017
  10. vakrilov commented on Jul 28, 2017

    @vakrilov
    Contributor

    @EddyVerbruggen Thanks for the great PR - it is merged now.
    @SvetoslavTsenov Can you please add this scenario in the e2e tests for the action-bar.

  11. SvetoslavTsenov commented on Jul 31, 2017

    @SvetoslavTsenov
    Contributor

    A test is already included but I found an issue on iOS. When we update the flat prop. from code behind it doesn't update the UI.
    Here is the sample page that we use:
    https://github.com/NativeScript/NativeScript/blob/master/apps/app/ui-tests-app/action-bar/flat.ts
    Please have in mind that so far for Android is it working perfectly fine.

  12. removed
    ready for testTSC needs to test this and confirm against live production apps and automated test suites
    on Aug 2, 2017
  13. lock commented on Aug 28, 2019

    @lock

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  14. locked and limited conversation to collaborators on Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions