chore: fix Apache-2.0 license notice and attribution gaps - #2605
Open
rparolin wants to merge 1 commit into
Open
Conversation
An open-source license review flagged several Apache-2.0 compliance gaps.
This addresses three of them, plus the guard that let one class of them
through. Licensing metadata only; no logic changes.
Copyright notices (15 files)
Two different defects that happened to share a symptom:
- 14 files under cuda_bindings/examples/ carried a non-standard notice
("Copyright 2021-2026 NVIDIA Corporation. All rights reserved.") with
no (c), no SPDX-FileCopyrightText prefix, and the wrong entity casing.
- toolshed/conda_create_for_pathfinder_testing.ps1 had the correct prefix
and casing but was truncated before "& AFFILIATES. All rights reserved.".
All now carry the canonical string. Years are preserved as found.
Header guard (toolshed/check_spdx.py)
COPYRIGHT_REGEX made "& AFFILIATES. All rights reserved." optional, so a
bare "NVIDIA CORPORATION" satisfied pre-commit. The suffix is now
required. (The 14 example files were passing for a different reason:
.spdx-ignore excludes cuda_bindings/examples/ entirely. That exclusion is
left alone here, but the files now conform, so it can be dropped in a
follow-up if desired.)
Tightening the regex surfaced two pre-existing files whose notice was
split or truncated -- cuda_core/cuda/core/_include/layout.hpp and
toolshed/build_static_bitcode_input.py. Both are corrected so the
mandated sentence appears verbatim on one line.
Third-party attribution (cuda_core/NOTICE)
cuda/core/_include/aoti_shim.h is a vendored subset of PyTorch's AOT
Inductor stable C ABI, BSD-3-Clause, carrying the upstream Facebook,
Idiap, Deepmind, NEC and NYU copyright lines, but NOTICE listed only
DLPack. A PyTorch entry is added with the full copyright block. The
accompanying aoti_shim.def carries no copyright line of its own and is
covered explicitly by that entry rather than given an NVIDIA header,
since it declares the same upstream symbol names. The DLPack entry now
also records where it is vendored.
LICENSE files (all five)
Every LICENSE ended at "END OF TERMS AND CONDITIONS", omitting the
required "APPENDIX: How to apply the Apache License to your work" and
its boilerplate. Appended to all five. The text is verified identical
to the canonical Apache 2.0 appendix.
Verified: 0 files with a non-conforming copyright string; check_spdx.py
passes over all 868 in-scope tracked files with the tightened regex.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Rob Parolin <rparolin@nvidia.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An open-source license review flagged four Apache-2.0 compliance gaps. This fixes three of them, plus the guard that let one class of them through. Licensing metadata only — no logic changes.
1. Copyright notices (15 files). Two defects with the same symptom:
cuda_bindings/examples/readCopyright 2021-2026 NVIDIA Corporation. All rights reserved.— no(c), noSPDX-FileCopyrightText:prefix, wrong entity casing.toolshed/conda_create_for_pathfinder_testing.ps1had the right prefix and casing but stopped before& AFFILIATES. All rights reserved.All now use the required string. Years preserved as found.
2. The header guard (
toolshed/check_spdx.py). Its regex made& AFFILIATES. All rights reserved.optional, so a bareNVIDIA CORPORATIONpassed pre-commit. Now required.Two notes for reviewers:
.spdx-ignoreexcludescuda_bindings/examples/entirely. I left that exclusion alone, but those files now conform, so it can be dropped in a follow-up if you want them guarded.cuda_core/cuda/core/_include/layout.hppandtoolshed/build_static_bitcode_input.py. Both fixed so the sentence appears verbatim on one line.3. Third-party attribution (
cuda_core/NOTICE).cuda/core/_include/aoti_shim.his a vendored subset of PyTorch's AOT Inductor stable C ABI (BSD-3-Clause, with upstream Facebook/Idiap/Deepmind/NEC/NYU copyright lines), but NOTICE listed only DLPack. Added a PyTorch entry with the full copyright block.aoti_shim.defhas no copyright line of its own. It's covered by that NOTICE entry rather than given an NVIDIA header, since it declares the same upstream symbol names.4. LICENSE files (all five). Each ended at
END OF TERMS AND CONDITIONS, omitting the requiredAPPENDIX: How to apply the Apache License to your workand its boilerplate. Appended to all five; text verified identical to the canonical Apache 2.0 appendix.Not addressed here: the four sub-component
LICENSEfiles (cuda_core/,cuda_bindings/,cuda_python/,cuda_pathfinder/) duplicate the root one. That needs a decision — delete them, or reference each from the root README — so it's left for a separate PR.There is no linked issue for this; it came out of a license review rather than a bug report.
🤖 Generated with Claude Code