cuda.core: validate ctypes host callback signatures against CUhostFn - #2525
Open
Andy-Jost wants to merge 2 commits into
Open
cuda.core: validate ctypes host callback signatures against CUhostFn#2525Andy-Jost wants to merge 2 commits into
Andy-Jost wants to merge 2 commits into
Conversation
Reject incompatible ctypes prototypes before CUDA sees them, document the required ABI, and note the stronger checking in the 1.2.0 release notes.
Use getattr for private ctypes calling-convention constants so the regenerated _host_callback.pyi type-checks cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2439.
cuda.coreaccepted anyctypes._CFuncPtras a host callback and cast its address toCUhostFnwithout checking the declared prototype. CUDA requiresvoid (*)(void*); a mismatched restype, argument list, or calling convention is undefined behavior when the driver invokes the callback._resolve_host_callbacknow validates ctypes prototypes against that ABI before the pointer reaches CUDA. Construction (GraphNode.callback/GraphBuilder.callback) and update paths share the check. ValidCFUNCTYPE(None, c_void_p)callbacks keep working; on WindowsWINFUNCTYPEis also accepted. Docs, stubs, and the 1.2.0 release notes are updated accordingly.Changes
TypeError(message namesCUhostFnand suggests a conforming declaration or a Python callable)callback/updateAPIsWINFUNCTYPEaccept, skipped on Linux)cuda_core/docs/source/release/1.2.0-notes.rst