Skip to content

[https://nvbugs/6248776][fix] Add trust_remote_code=True to the LLM(...) call in test_nemotron_nas_lora and…#14958

Open
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6248776
Open

[https://nvbugs/6248776][fix] Add trust_remote_code=True to the LLM(...) call in test_nemotron_nas_lora and…#14958
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6248776

Conversation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

@tensorrt-cicd tensorrt-cicd commented Jun 4, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Root cause: The nemotron-nas checkpoint ships a custom DeciLMConfig (auto_map); transformers 5.5.x enforces trust_remote_code=True, but test_nemotron_nas_lora constructed LLM(...) without it, so config load raised ValueError in the executor worker.
  • Fix: Add trust_remote_code=True to the LLM(...) call in test_nemotron_nas_lora and remove the two now-passing waiver lines.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Tests
    • Removed test waivers and enhanced test configuration parameters to improve test stability and coverage.

@tensorrt-cicd
[nvbugs/6248776][fix] Pass trust_remote_code=True in test_nemotron_na…
33f03d8 
…s_lora

The Llama-3_3-Nemotron-Super-49B-v1 checkpoint ships a custom DeciLMConfig
(auto_map) to parse its block_configs. transformers 5.5.x enforces
trust_remote_code=True for such repos, so AutoConfig.from_pretrained raised
ValueError during executor-worker config load. The test constructed LLM(...)
without the flag; add it to match the existing pattern for custom-code models,
and remove the now-passing waivers.

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 40c6b658-7f1a-4550-9082-e8221c7e3a29

📥 Commits

Reviewing files that changed from the base of the PR and between 8361d42 and 33f03d8.

📒 Files selected for processing (2)
  • tests/integration/test_lists/waives.txt
  • tests/unittest/llmapi/test_llm_pytorch.py
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

This PR adds trust_remote_code=True to the test_nemotron_nas_lora test's LLM constructor call to enable remote code trust for model loading, and removes two corresponding waiver entries from the test skip list that are no longer required.

Changes

Remote code trust for Nemotron test

Layer / File(s) Summary
Add trust_remote_code parameter and remove waivers
tests/unittest/llmapi/test_llm_pytorch.py, tests/integration/test_lists/waives.txt		 The test_nemotron_nas_lora test now passes trust_remote_code=True to the LLM constructor alongside cuda_graph_config. Two waiver entries for this test's None and cuda_graph_config0 parameterizations are removed from the skip list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • xinhe-nv
  • StanleySun639
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main fix: adding trust_remote_code=True to test_nemotron_nas_lora and removing waivers, directly matching the changeset.
Description check ✅ Passed The description explains the root cause, solution, test plan, and includes relevant bug link. While PR checklist items aren't checked off, the key sections are substantively complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shaharmor98 shaharmor98

@tensorrt-cicd tensorrt-cicd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tensorrt-cicd @shaharmor98