Skip to content

sign message result not showing - #1719

Merged
gamalielhere merged 6 commits into
devop/prep-releasefrom
bug/sign-message-no-show
Dec 6, 2019
Merged

gamalielhere merged 6 commits into
devop/prep-releasefrom
bug/sign-message-no-show

Conversation

@SteveMieskoski

@SteveMieskoski SteveMieskoski commented Dec 5, 2019 •

Copy link
Copy Markdown
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@SteveMieskoski SteveMieskoski added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Fixed Issue is fixed waiting for merge labels Dec 5, 2019
@SteveMieskoski SteveMieskoski added the Ready Tag for when a PR is ready to merge label Dec 5, 2019
@codecov

codecov Bot commented Dec 6, 2019 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (devop/prep-release@d35d74a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             devop/prep-release   #1719   +/-   ##
====================================================
  Coverage                      ?     14%           
====================================================
  Files                         ?     429           
  Lines                         ?   14414           
  Branches                      ?    2627           
====================================================
  Hits                          ?    2018           
  Misses                        ?   11608           
  Partials                      ?     788
Impacted Files Coverage Δ
...ners/SignMessageContainer/SignMessageContainer.vue 20% <0%> (ø)
...rs/ConfirmationContainer/ConfirmationContainer.vue 14.49% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d74a...a23e5f4. Read the comment docs.

@gamalielhere
gamalielhere changed the base branch from develop to devop/prep-release December 6, 2019 19:47
@gamalielhere
gamalielhere merged commit 65e22a0 into devop/prep-release Dec 6, 2019
@gamalielhere
gamalielhere deleted the bug/sign-message-no-show branch December 6, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Fixed Issue is fixed waiting for merge Hotfix Ready Tag for when a PR is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants