Validate maximum DDC overrides#1878
Open
offyotto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum DDC override accepts any unsigned integer, then narrows it through
IntandUInt16. Values above 65,535 can crash when entered or when the DDC value is converted.Accept only values from 0 through 65,535, matching the minimum override. Invalid values clear the override as before.
ran tests:
xcodebuild -project MonitorControl.xcodeproj -scheme MonitorControl -configuration Debug -derivedDataPath /tmp/MonitorControlDerivedData CODE_SIGNING_ALLOWED=NO build(BUILD SUCCEEDED)on M1 Pro mbp 14in (macOS 26.5)