Skip to content

Downgrade SkiaSharp and ScottPlot for Server 2012 R2#28

Merged
ModerRAS merged 1 commit into
masterfrom
codex/skiasharp-version-fix
May 15, 2026
Merged

Downgrade SkiaSharp and ScottPlot for Server 2012 R2#28
ModerRAS merged 1 commit into
masterfrom
codex/skiasharp-version-fix

Conversation

@ModerRAS

@ModerRAS ModerRAS commented May 15, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores

    • Downgraded SkiaSharp NuGet package from version 3.116.1 to 2.88.9
    • Downgraded ScottPlot packages from version 5.1.57 to 5.0.55 across multiple projects
  • Refactor

    • Improved text measurement operations in cable routing visualization

Review Change Stack

@ModerRAS ModerRAS merged commit 524b78b into master May 15, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc6f2291-8c22-41ea-9442-c534b3c01c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5d681 and 41cb46d.

📒 Files selected for processing (6)
  • ModerBox.CableRouting/CableRenderer.cs
  • ModerBox.CableRouting/ModerBox.CableRouting.csproj
  • ModerBox.Comtrade.Analysis.CurrentDifference/ModerBox.Comtrade.Analysis.CurrentDifference.csproj
  • ModerBox.Comtrade.CurrentDifferenceAnalysis/ModerBox.Comtrade.CurrentDifferenceAnalysis.csproj
  • ModerBox.Comtrade.FilterWaveform/ModerBox.Comtrade.FilterWaveform.csproj
  • ModerBox/ModerBox.csproj

📝 Walkthrough

Walkthrough

CableRenderer refactors text measurement in DrawPoints and DrawEndTable to use preconfigured paint objects with antialiasing, typeface, and font size. SkiaSharp is downgraded from 3.116.1 to 2.88.9. ScottPlot and ScottPlot.Avalonia are downgraded from 5.1.57 to 5.0.55 across five projects.

Changes

Cable Text Measurement Refactoring

Layer / File(s) Summary
Cable text measurement consolidation
ModerBox.CableRouting/CableRenderer.cs
DrawPoints and DrawEndTable now create a preconfigured measurePaint with antialiasing, typeface, and font size, then use measurePaint.MeasureText() instead of external paint parameter passing to font.MeasureText().
SkiaSharp version downgrade
ModerBox.CableRouting/ModerBox.CableRouting.csproj
SkiaSharp dependency updated from 3.116.1 to 2.88.9.

ScottPlot Dependency Downgrades

Layer / File(s) Summary
ScottPlot version synchronization across projects
ModerBox/ModerBox.csproj, ModerBox.Comtrade.FilterWaveform/ModerBox.Comtrade.FilterWaveform.csproj, ModerBox.Comtrade.CurrentDifferenceAnalysis/ModerBox.Comtrade.CurrentDifferenceAnalysis.csproj, ModerBox.Comtrade.Analysis.CurrentDifference/ModerBox.Comtrade.Analysis.CurrentDifference.csproj
ScottPlot and ScottPlot.Avalonia packages downgraded from 5.1.57 to 5.0.55 in all five projects; FilterWaveform includes a Windows Server 2012 R2 compatibility note.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A paint brush dipped with care and font,
No measure calls need stumble on.
SkiaSharp drops, ScottPlot too—
Versions aligned for all to use! 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skiasharp-version-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Code Coverage Report

  • Minimum Required Coverage: 50%
  • Current Coverage: 62.25%

📄 View Full Report

🚀 Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant