Skip to content

Added note from SET XACT_ABORT#7494

Merged
Court72 merged 2 commits into
MicrosoftDocs:livefrom
jonathanmbaker:patch-2
Apr 20, 2022
Merged

Added note from SET XACT_ABORT#7494
Court72 merged 2 commits into
MicrosoftDocs:livefrom
jonathanmbaker:patch-2

Conversation

@jonathanmbaker
Copy link
Copy Markdown
Contributor

Extra note from SET XACT_ABORT page seems important as it is the best reason to prefer THROW over RAISERROR, and so far not mentioned

"The THROW statement honors SET XACT_ABORT. RAISERROR does not. New applications should use THROW instead of RAISERROR."

Extra note from SET XACT_ABORT page  seems important as it is the best reason to prefer THROW over RAISERROR, and so far not mentioned
@PRMerger10
Copy link
Copy Markdown
Contributor

@jonathanmbaker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Comment thread docs/t-sql/language-elements/throw-transact-sql.md Outdated
@Court72
Copy link
Copy Markdown
Contributor

Court72 commented Apr 20, 2022

@LitKnd

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"

@PRMerger5 PRMerger5 added the aq-pr-triaged tracking label for the PR review team label Apr 20, 2022
@LitKnd
Copy link
Copy Markdown
Contributor

LitKnd commented Apr 20, 2022

Hi @jonathanmbaker ,

Thanks for creating this PR. Could you please review the suggestion made by @Court72 ? The links you provided are great, but for localization reasons we don't commit the location signifier (in this case "en-us") in URLs.

If you are not familiar with the GitHub suggestion feature, it should allow you to commit the suggestion from the 'files changed' tab on this PR.

Thanks again for submitting this PR,
Kendra from the Database Docs Team

@PRMerger17
Copy link
Copy Markdown
Contributor

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Copy Markdown
Contributor

Court72 commented Apr 20, 2022

Thanks, @LitKnd. I went ahead and committed the update.

If the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

Thanks!

@LitKnd
Copy link
Copy Markdown
Contributor

LitKnd commented Apr 20, 2022

Aha, thanks @Court72 , I misunderstood your previous comment. That looks great.

@jonathanmbaker , please ignore my prior comment -- you don't need to accept the suggestion. Thanks again for submitting this change.

Kendra from the Database Docs Team

#sign-off

@Court72 Court72 merged commit 6626c2e into MicrosoftDocs:live Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants