Improved memory-related wording#6181
Merged
Merged
Conversation
The current wording is incorrect. It suggests that as soon as you start using sp_xml_preparedocument that you lose 1/8 of SQL Server's memory. This is demonstratably not true. That's a limit. In addition, a suggestion is added that the nodes() method might be a better alternative in many cases, and avoid this issue in the first place.
Contributor
|
@greglow-sdu : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Member
|
#sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wording is incorrect. It suggests that as soon as you start using sp_xml_preparedocument that you lose 1/8 of SQL Server's memory. It's easy to show that this is not true. That's a limit. In addition, a suggestion is added that the nodes() method might be a better alternative in many cases, and avoid this issue in the first place. A reference to it was also added.