Skip to content

Standardize See also sections#767

Merged
colin-home merged 11 commits into
MicrosoftDocs:masterfrom
nxtn:master
Feb 6, 2019
Merged

Standardize See also sections#767
colin-home merged 11 commits into
MicrosoftDocs:masterfrom
nxtn:master

Conversation

@nxtn
Copy link
Copy Markdown
Contributor

@nxtn nxtn commented Feb 4, 2019

Get ready for the following PR.

@PRMerger14
Copy link
Copy Markdown
Contributor

@NextTurn : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@colin-home
Copy link
Copy Markdown
Contributor

@NextTurn Thanks for spotting and fixing the link formatting typos. This is a good start, and we appreciate your response to the mistakes we made. One of our mistakes was, ## See also sections should only occur once at the end of an article, not multiple times in the middle, as was done in these when they were merged from multiple sources. If you feel up to moving and merging the ## See also sections (note sentence-style capitalization) into a single section at the end of the article, then by all means, continue. You'll have our gratitude.

@PRMerger16
Copy link
Copy Markdown
Contributor

@NextTurn : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Feb 4, 2019

Thanks for your quick reply @corob-msft. I've merged the sections in the middle into one, and I'll fix the rest in the next PR.

I spotted some [label](#anchor) self-referencing links, which may be redundant now.

Removed unneeded See also link.
@PRMerger15
Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Remove unneeded See also links.
@PRMerger15
Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Colin Robertson added 3 commits February 5, 2019 13:40
Remove redundant path segments in See also links.
Remove internal anchor links from See also section.
Remove internal anchor links from See also section.
@PRMerger17
Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Colin Robertson added 4 commits February 5, 2019 13:49
Remove unneeded internal anchor links from See also section.
Remove broken internal anchor link from See also section.
Remove unneeded internal anchor links in See also section.
Fix broken links in See also section.
Copy link
Copy Markdown
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NextTurn Excellent work, thanks very much for seeing these through. I fixed up a handful of them to remove unneeded internal links, and spotted a couple of other pre-existing issues to fix as well. Looks good!

@colin-home
Copy link
Copy Markdown
Contributor

@NextTurn Only one thing left - sign the CLA agreement for these changes to be merged.

@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Feb 5, 2019

@corob-msft There used to be a CLA bot, but I can't find it now.

@colin-home
Copy link
Copy Markdown
Contributor

Hmm, curious. Could I have done something to it by contributing the patches? I'll see what I can find out.

@nxtn nxtn closed this Feb 6, 2019
@nxtn nxtn reopened this Feb 6, 2019
@PRMerger15
Copy link
Copy Markdown
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Feb 6, 2019

Done by reopening!

@colin-home
Copy link
Copy Markdown
Contributor

I should have tried that; it's fixed other issues before. Thanks for dealing with it.

@colin-home colin-home merged commit e4457e2 into MicrosoftDocs:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants