Skip to content

Fix git push error for protected CLA branch#637

Merged
colin-home merged 4 commits into
masterfrom
master636807619153565393
Dec 18, 2018
Merged

Fix git push error for protected CLA branch#637
colin-home merged 4 commits into
masterfrom
master636807619153565393

Conversation

@fenxu
Copy link
Copy Markdown
Collaborator

@fenxu fenxu commented Dec 18, 2018

The pull request is created from master636807619153565393 to master to fix git push error for protected CLA branch

Colin Robertson and others added 4 commits December 16, 2018 19:59
@PRMerger14
Copy link
Copy Markdown
Contributor

@Taojunshen : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@Jak-MS
Copy link
Copy Markdown
Contributor

Jak-MS commented Dec 18, 2018

the doc doesn't have a listed ms.author. @corob-msft or @Mikejo5000 - can you take a look and sign off if this changes is approved? thanks.

@Jak-MS Jak-MS assigned colin-home and Mikejo5000 and unassigned Mikejo5000 Dec 18, 2018
@Jak-MS
Copy link
Copy Markdown
Contributor

Jak-MS commented Dec 18, 2018

@fenxu,

Since you're a Microsoft employee. In the future, please make content contributions through the private repository so the content can be staged and validated by the current validation rules.

Read about working in the public repo for more information.

Thank you.

@colin-home colin-home merged commit b5b304c into master Dec 18, 2018
@colin-home
Copy link
Copy Markdown
Contributor

@Jak-MS In the cpp-docs-pr and cpp-docs repos, the author fields are set at folder level in docfx.json, along with most other common metadata fields. It looks like this may be breaking some automation.

@Jak-MS
Copy link
Copy Markdown
Contributor

Jak-MS commented Dec 18, 2018

@corob-msft - thanks!

@colin-home colin-home deleted the master636807619153565393 branch February 6, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants