demotion-of-integers.md: Fix example#5223
Merged
Merged
Conversation
Contributor
|
@Alcaro : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit ebacb40: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
TylerMSFT
approved these changes
Mar 6, 2025
TylerMSFT
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this fix. Excellent.
Collaborator
|
#sign-off |
Contributor
|
@Alcaro : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-2 isn't 0xFE.
(char)-2is 0xFE, but IMO adding a type cast would distract from the point of that page; instead, let's switch to integers' default size.