Correct return value of CTaskDialog::OnHelp()#5176
Conversation
It returns `S_FALSE`, not `S_OK`, according to `afxtaskdialog.cpp` in 14.42.34433. In testing, returning `S_OK` from an overridden implementation may result in another window (e.g., a main frame window) also presenting help.
|
@JoshHarmon : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 629fc83: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
I should note that the fact there is a behavior change based on return value suggests to me that the page for TDN_HELP also is likely to contain bogus claims, such the claim that "The return value is ignored." |
There was a problem hiding this comment.
@JoshHarmon, thank you for this fix. I verify the same.
I'll notify the owner of the other doc.
As an aside, my verification process included looking at another topic about the CTaskDialog, which I was able to substantially update. So, your good turn had good knock-on effects.
|
#sign-off |
It returns
S_FALSE, notS_OK, according toafxtaskdialog.cppin 14.42.34433.In testing, returning
S_OKfrom an overridden implementation to match the described "default" implementation may result in another window (e.g., a main frame window) also presenting help.