Fix MASM dot-code and dot-data to indicate they also work on x64 - #5134
Merged
Conversation
Contributor
|
Nir Lichtman (@nir9) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 807f208: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit 07887f4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Tyler Whitney (TylerMSFT)
approved these changes
Dec 5, 2024
Tyler Whitney (TylerMSFT)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for improving the clarity.
Collaborator
|
#sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Current documentation of .DATA and .CODE is confusing since it starts with a sentence that says 32 bit only which can lead to a misunderstanding that it is not supported in x64