Skip to content

Update how-to-create-and-use-shared-ptr-instances.md - #5131

Merged
Courtney Wales (Court72) merged 3 commits into
MicrosoftDocs:mainfrom
ModulePillow:main
Dec 4, 2024
Merged

Update how-to-create-and-use-shared-ptr-instances.md#5131
Courtney Wales (Court72) merged 3 commits into
MicrosoftDocs:mainfrom
ModulePillow:main

Conversation

@ModulePillow

Copy link
Copy Markdown
Contributor

The old description about shared_ptr is wrong.

If we pass a raw ptr to a callee func, and use it to create a new shared_ptr, it's dangerous because callee will delete the resource where raw ptr pointed to.

Please accept this revision.
image

Adjust some wrong description about shared_ptr
@prmerger-automator

Copy link
Copy Markdown
Contributor

@Nowhere6 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8f4542d:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT)

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Dec 2, 2024
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit af22544:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding clarity around this scenario.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit e524ab0:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/how-to-create-and-use-shared-ptr-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT

Copy link
Copy Markdown
Collaborator

#sign-off

@Court72
Courtney Wales (Court72) merged commit c9a7a4a into MicrosoftDocs:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants