Skip to content

Update clang-tidy.md#4948

Merged
Jak-MS merged 7 commits into
MicrosoftDocs:mainfrom
sinemakinci1:main
Feb 28, 2024
Merged

Update clang-tidy.md#4948
Jak-MS merged 7 commits into
MicrosoftDocs:mainfrom
sinemakinci1:main

Conversation

@sinemakinci1
Copy link
Copy Markdown
Contributor

Adding support for CMake Presets

Adding support for CMake Presets
@prmerger-automator
Copy link
Copy Markdown
Contributor

@sinemakinci1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 0c23813:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
@Jak-MS
Copy link
Copy Markdown
Contributor

Jak-MS commented Feb 21, 2024

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Feb 21, 2024
addressing some feedback
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit ea7939d:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@sinemakinci1
Copy link
Copy Markdown
Contributor Author

@TylerMSFT can you take a look at the updates now?

Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Copy link
Copy Markdown
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sinem! Left a couple comments.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@sinemakinci1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sinemakinci1
Copy link
Copy Markdown
Contributor Author

@TylerMSFT updated, thanks for your additional review!

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit a52b023:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 01ec199:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Comment thread docs/code-quality/clang-tidy.md Outdated
Comment thread docs/code-quality/clang-tidy.md Outdated
Copy link
Copy Markdown
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed a tagging issue for the code blocks.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 6de2ecf:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Copy Markdown
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sinem!

Comment thread docs/code-quality/clang-tidy.md Outdated
@Jak-MS Jak-MS merged commit 2bf26aa into MicrosoftDocs:main Feb 28, 2024
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit d90f8ad:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 474bf33:

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/clang-tidy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants