Skip to content

Document warning C5267 - #4807

Closed
Rageking8 wants to merge 8 commits into
MicrosoftDocs:mainfrom
Rageking8:document-warning-c5267
Closed

Document warning C5267#4807
Rageking8 wants to merge 8 commits into
MicrosoftDocs:mainfrom
Rageking8:document-warning-c5267

Conversation

@Rageking8

Copy link
Copy Markdown
Contributor

I accidentally stumbled upon this new warning code by misreading the following sentence as it "emitting a warning" (instead of it not emitting, as shown below)

> In both cases, Visual Studio continues to automatically generate the necessary functions implicitly, and does not emit a warning.

So this PR just documented this relatively new warning code.

@prmerger-automator

Copy link
Copy Markdown
Contributor

Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit bc69614:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/c5267.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT)

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Nov 8, 2023
@TylerMSFT

Copy link
Copy Markdown
Collaborator

Rageking8, thanks! Appreciate the new documentation.
I have a number of new articles I need to write, so it may be a bit before I can get to reviewing this and integrating it into the docs. I will loop back to this when I can. The dev team frequently writes drafts for the new warning topics. I'll need to check that this doesn't duplicate their efforts. Take care.

@TylerMSFT

Copy link
Copy Markdown
Collaborator

Rageking8, I ran this past the dev team and they weren't already working on it, so we'll be pleased to take this contribution. And they are aware that this exists so they won't go off now and duplicate the effort. Thank you! I'm getting ready for a release so I have to focus on some other content for a few days. Then I'll come back to this. Thanks for adding to the docs!

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit fb48724:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/c5267.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 9229c41:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/c5267.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Hopefully clarify that although it is decpreated, it is still supported.
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 10c0b21:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/error-messages/compiler-warnings/c5267.md ⚠️Warning Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

  • Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 829ad6e:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/error-messages/compiler-warnings/c5267.md ⚠️Warning Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

  • Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

last edits

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Rageking8!

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit c40ec45:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/error-messages/compiler-warnings/c5267.md ⚠️Warning Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

  • Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 44140ab:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md ✅Succeeded
docs/error-messages/compiler-warnings/c5267.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT

Copy link
Copy Markdown
Collaborator

#sign-off

@Jak-MS

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT) - because this PR includes a new article, the commits will need to be moved to the private repo so we can review on staging. can you move them or would you like our assistance?

@Jak-MS

Copy link
Copy Markdown
Contributor

#hold-off

@TylerMSFT

Copy link
Copy Markdown
Collaborator

Jak Koke (@Jak-MS) - could you be so kind as to move it over to our private repo?

@TylerMSFT

Copy link
Copy Markdown
Collaborator

Rageking8, because of the new article, I must port this PR over to the private repo, where we do additional validation. I've ported the PR over, and am working through getting it published.
We can close this now. Your work is in the private repo now.
Thanks for giving us a new warning topic!

@TylerMSFT

Copy link
Copy Markdown
Collaborator

Rageking8, I got this ported. It should be live by tomorrow. Thanks for the content!

@Rageking8
Rageking8 deleted the document-warning-c5267 branch November 16, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants