Skip to content

Clean up C2397 - #4743

Merged
Shannon Leavitt (ShannonLeavitt) merged 1 commit into
MicrosoftDocs:mainfrom
Rageking8:clean-up-c2397
Oct 18, 2023
Merged

Clean up C2397#4743
Shannon Leavitt (ShannonLeavitt) merged 1 commit into
MicrosoftDocs:mainfrom
Rageking8:clean-up-c2397

Conversation

@Rageking8

@Rageking8 Rageking8 commented Oct 1, 2023

Copy link
Copy Markdown
Contributor

Make the example more uniform with the others, remove the need to use std::vector and made the doubles in the initializers more explicit (2 -> 2.0). Also made the code block cpp to get proper syntax highlighting on the page.

@prmerger-automator

Copy link
Copy Markdown
Contributor

Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit de37bf1:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2397.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT)

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Oct 2, 2023

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your example is better than what was in there. Much thanks!

@TylerMSFT

Copy link
Copy Markdown
Collaborator

#sign-off

@ShannonLeavitt

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

@Rageking8
Rageking8 deleted the clean-up-c2397 branch November 3, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants