masm/bnf-grammar: Format some literal characters correctly - #4456
Conversation
A couple of character literal terminals don't follow consistent formatting. Fix that.
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
4 similar comments
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit b3dc4de: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Tyler Whitney (TylerMSFT)
left a comment
There was a problem hiding this comment.
I'm on the fence about the value of these changes. One of the reasons we do code escape is to prevent machine translation of identifiers. But that's not an issue with parenthesis, etc.
I'll take the change since the work is done, but I wouldn't necessarily encourage further work like this unless it is to prevent machine translation from incorrectly modifying a code statement.
|
#sign-off |
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
1 similar comment
|
Lubomir Rintel (@lkundrak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Tyler Whitney (TylerMSFT)
left a comment
There was a problem hiding this comment.
Hi, thanks for the changes.
A couple of character literal terminals don't follow consistent formatting. Fix that.