Update tutorial-import-stl-named-module.md#4429
Conversation
The Title of the document doesn't reveal that this procedure is only for a command line case. Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
4 similar comments
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 2f40001: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
TylerMSFT
left a comment
There was a problem hiding this comment.
Thank you. As a small request, could you please make 'Command Line' lowercase? We don't use that casing in headings.
Changed the capitalization at Microsoft's request.
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 45bb818: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
TylerMSFT
left a comment
There was a problem hiding this comment.
Hi, I meant change the text that is visible - the heading.
I'll send this through and fix it later today.
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#4817) * Update vcperf-commands.md (#4375) * Update vcperf-commands.md Update commands according to https://github.com/microsoft/vcperf#command-line-reference * Update vcperf-commands.md * Update with grammar fixes for i18n --------- Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com> * Update tutorial-import-stl-named-module.md (#4429) * Update tutorial-import-stl-named-module.md The Title of the document doesn't reveal that this procedure is only for a command line case. Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation. * Update tutorial-import-stl-named-module.md Changed the capitalization at Microsoft's request. --------- Co-authored-by: huypub <38988242+huypub@users.noreply.github.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: Nelson Daniel Troncoso <nd.ta@hotmail.com> Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com> Co-authored-by: Centurion Maximus <ddminnl@gmail.com>
* rewording ReadString documentation to be more accurate (#4815) * reword nmax parameter wording for ReadString to be more accurate * change suggested directory location * acrolinx * incorp review * fix path * improve path * Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#4817) * Update vcperf-commands.md (#4375) * Update vcperf-commands.md Update commands according to https://github.com/microsoft/vcperf#command-line-reference * Update vcperf-commands.md * Update with grammar fixes for i18n --------- Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com> * Update tutorial-import-stl-named-module.md (#4429) * Update tutorial-import-stl-named-module.md The Title of the document doesn't reveal that this procedure is only for a command line case. Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation. * Update tutorial-import-stl-named-module.md Changed the capitalization at Microsoft's request. --------- Co-authored-by: huypub <38988242+huypub@users.noreply.github.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: Nelson Daniel Troncoso <nd.ta@hotmail.com> Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com> Co-authored-by: Centurion Maximus <ddminnl@gmail.com> * fix casing and wording * acrolinx --------- Co-authored-by: Anju del Moral Gonzalez <judelmor@microsoft.com> Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: huypub <38988242+huypub@users.noreply.github.com> Co-authored-by: Nelson Daniel Troncoso <nd.ta@hotmail.com> Co-authored-by: Colin Robertson <3836425+corob-msft@users.noreply.github.com> Co-authored-by: Centurion Maximus <ddminnl@gmail.com> Co-authored-by: Jak Koke <v-jokoke@microsoft.com>
|
Sorry, I was having problems figuring out how to make that change in the PR
interface and didn't think it through.
Thanks for dealing with it.
…On Thu., Feb. 23, 2023, 09:31 Tyler Whitney, ***@***.***> wrote:
***@***.**** approved this pull request.
Hi, I meant change the text that is visible - the heading.
I'll send this through and fix it later today.
—
Reply to this email directly, view it on GitHub
<#4429 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEVLIVBC6LZMYBY6QZREM3WY6GGFANCNFSM6AAAAAAVDWGKNE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@JustaSimpleUser , no worries. The important thing is that we got your improvement in, and I think it was a good thing to add. Thank you for taking the time. |
The Title of the document doesn't reveal that this procedure is only for a command line case. Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.