Skip to content

virtual functions can be constexpr#4425

Merged
colin-home merged 2 commits into
MicrosoftDocs:mainfrom
fsb4000:patch-2
Feb 21, 2023
Merged

virtual functions can be constexpr#4425
colin-home merged 2 commits into
MicrosoftDocs:mainfrom
fsb4000:patch-2

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented Feb 18, 2023

Fixes #4245

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

4 similar comments
@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 65f8e27:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/constexpr-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 4c8d7a2:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/constexpr-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Copy Markdown
Contributor

Court72 commented Feb 20, 2023

@corob-msft

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Feb 20, 2023
@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Some passive constructions can't be avoided.
@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 3221455:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/constexpr-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Copy Markdown
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsb4000 Thanks for the update. Let's see how long it takes to make it into the top search results for "can a constexpr function be virtual".

@colin-home colin-home merged commit 5c139f2 into MicrosoftDocs:main Feb 21, 2023
@fsb4000 fsb4000 deleted the patch-2 branch February 21, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Article on constexpr incorrectly states that virtual functions can't be constexpr

3 participants