Skip to content

Fix shift operators code examples#345

Merged
colin-home merged 3 commits into
MicrosoftDocs:masterfrom
oboukli:code-example-fixes
Aug 13, 2018
Merged

Fix shift operators code examples#345
colin-home merged 3 commits into
MicrosoftDocs:masterfrom
oboukli:code-example-fixes

Conversation

@oboukli
Copy link
Copy Markdown
Contributor

@oboukli oboukli commented Jul 14, 2018

Revise and fix code example compilation errors, in particular error C2398: Element '1': conversion from 'short' to 'unsigned __int64' requires a narrowing conversion.

@PRMerger7
Copy link
Copy Markdown
Contributor

@oboukli : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

- Add C++14-style comments for readability
- Fix some formatting and trailing space issues
@PRMerger20
Copy link
Copy Markdown
Contributor

@oboukli : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

Copy link
Copy Markdown
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks!

@PRMerger8
Copy link
Copy Markdown
Contributor

@oboukli : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

@colin-home colin-home merged commit ffa8b37 into MicrosoftDocs:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants