?! what are you talking about#1093
Merged
Merged
Conversation
This is the truth... "Returns **true** if the condition is detected at each element in the indicated range or if the range is empty, and **false** otherwise." Not.. "Returns true if the condition is detected at each element in the indicated range, and false if the condition is not detected at least one time. " "if the condition is not detected at least one time." this mean that you think if condition is detect at least one time all_of will return **true** which is not true.
Contributor
|
@EmilEnchev : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
colin-home
approved these changes
Jun 17, 2019
Contributor
colin-home
left a comment
There was a problem hiding this comment.
@EmilEnchev This is much clearer. Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me in such way is more clear.
"Returns true if the condition is detected at each element in the indicated range or if the range is empty, and false otherwise."
Please add "or if the range is empty" at lease. Because if range is empty all_of return true too.
P.s. I'm new in GitHub. Please if I'm wrong in some my actions on that how I do things here, tell me.