Skip to content

feat(social-controllers): route trader reads to the signed-in user's own route #11325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xavier-brochard wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(social-controllers): route trader reads to the signed-in user's own route #11325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e099f3
feat(social-controllers): route trader reads to the signed-in user's …
xavier-brochard Nov 5, 2026
4e03580
chore: merge main into feat/social-trader-me-routes
xavier-brochard Nov 5, 2026
69b34bc
fix(social-controllers): stop retrying owner-route 404 when probing a…
xavier-brochard Nov 5, 2026
29f1c00
docs(social-controllers): link unreleased changelog entries to PR 11325
xavier-brochard Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/social-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `TradingPrivacy` (`'public' | 'private'`) and an optional `tradingPrivacy` field on `TraderProfileResponse`. `TraderProfileResponseStruct` validates it, and responses from social-api builds that predate it still parse. Export `TradingPrivacy` ([#11325](https://github.com/MetaMask/core/pull/11325))
- Add an optional `profileId` to `FetchPositionByIdOptions`. When it is set, `fetchPositionById` picks the route from it without an extra request ([#11325](https://github.com/MetaMask/core/pull/11325))

### Changed

- `fetchTraderProfile`, `fetchOpenPositions`, `fetchClosedPositions`, `fetchTraderFeed`, and `fetchPositionById` are now viewer-aware (`SocialService:fetchTraderProfile`, and so on). When the trader is the signed-in user, they call the user's own `GET /v1/traders/me/...` route, which includes private trading. Otherwise they call the public route. The route is chosen inside `SocialService`, so callers do not pick it. Without a `profileId`, `fetchPositionById` tries the signed-in user's own route first and falls back to the public route on a 404. That 404 is not retried, so viewing someone else's position makes one owner route request before the public request. `fetchTraderProfile` rejects a profile response for a different profile than the one requested. The signed-in user is read from the subject of the bearer token. Responses are not cached across requests, so one signed-in user's data is not served to another ([#11325](https://github.com/MetaMask/core/pull/11325))

## [3.18.0]

### Added
Expand Down
45 changes: 16 additions & 29 deletions packages/social-controllers/src/SocialService-method-action-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@ export type SocialServiceFetchLeaderboardAction = {
};

/**
* Fetches a trader's profile by address or profile ID.
*
* Calls `GET ${baseUrl}/traders/${addressOrId}/profile`.
*
* `profile.createdAt` is optional. When present it is an ISO-8601 timestamp
* for when the social-api profile row was inserted.
* Fetches a trader's profile by address or profile ID, as the signed-in user
* may see it. The signed-in user's own profile comes from their own route,
* which includes private trading. Anyone else gets the public view, which
* withholds private trading. Pass the profile ID to get your own profile: a
* wallet address never matches the signed-in user.
*
* @param options - Options bag.
* @param options.addressOrId - Wallet address or Clicker profile ID.
* @param options.addressOrId - Profile ID, or wallet address.
* @returns The trader profile response.
*/
export type SocialServiceFetchTraderProfileAction = {
Expand Down Expand Up @@ -107,12 +106,15 @@ export type SocialServiceFetchTraderFollowingAction = {
};

/**
* Fetches a single position by its unique ID.
*
* Calls `GET ${baseUrl}/traders/position/${positionId}`.
* Fetches a single position by its unique ID, as the signed-in user may see
* it. A position the signed-in trader holds comes from their own route, which
* includes private trading. Pass `profileId`, the position's trader, to route
* directly. Without it, the signed-in user's own route is tried first, and the
* public route is used when that does not find the position.
*
* @param options - Options bag.
* @param options.positionId - Unique position ID (UUID).
* @param options.profileId - Profile ID of the position's trader, if known.
* @returns The position.
*/
export type SocialServiceFetchPositionByIdAction = {
Expand Down Expand Up @@ -150,27 +152,12 @@ export type SocialServiceFetchFeedAction = {
};

/**
* Fetches a page of one trader's activity as feed items.
*
* Calls `GET ${baseUrl}/traders/${addressOrId}/feed`. Unlike {@link fetchFeed},
* this is scoped to a single profile (open and closed positions in the feed)
* and does not accept `scope` or `chains`. Set `commentedOnly` to only return
* positions that carry an author comment.
*
* The route is public, but the Authorization header is still sent so the
* social-api can hydrate `authorComment.engagement.userReaction` for the
* signed-in viewer.
*
* Cursor pagination supports infinite scroll: pass `pagination.olderCursor`
* from a prior response back as `olderThan` to load older items, and
* `pagination.newerCursor` as `newerThan` to fetch newer items.
* Fetches a page of one trader's activity as feed items, as the signed-in user
* may see it. The signed-in trader's own feed comes from their own route, which
* includes private trading. Anyone else gets the public view.
*
* @param options - Options bag.
* @param options.addressOrId - Wallet address or Clicker profile ID.
* @param options.commentedOnly - When true, only positions with a comment.
* @param options.limit - Number of results per page.
* @param options.olderThan - Cursor for older items (scroll down).
* @param options.newerThan - Cursor for newer items (refresh).
* @param options.addressOrId - Profile ID, or wallet address.
* @returns The feed response with items and pagination cursors.
*/
export type SocialServiceFetchTraderFeedAction = {
Expand Down
Loading
Loading