Repository navigation
feat(assets-controllers): send x-mm-service-profile header in searchTokens - #11274
Open
Prithpal-Sooriya wants to merge 2 commits into
Open
Prithpal-Sooriya wants to merge 2 commits into
Prithpal-Sooriya wants to merge 2 commits into
Conversation
…okens Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds an optional
serviceProfileoption tosearchTokens(SearchTokenOptions). When set, the/tokens/searchrequest includes the headerx-mm-service-profile: <value>. Behavior is unchanged when unset. Mobile will passassets--trending-search.Jira: ASSETS-4243
Testing
yarn workspace @metamask/assets-controllers run testpasses; changelog validates; oxlint/oxfmt clean.🤖 Generated with Claude Code
Note
Low Risk
Small, backward-compatible extension to token search HTTP options with no change to default behavior.
Overview
Adds an optional
serviceProfilefield onsearchTokensoptions so callers can tag/tokens/searchrequests with thex-mm-service-profileheader (e.g. mobile’sassets--trending-search). When the option is omitted, the request is unchanged and the header is not sent.Unit tests assert the header is present only when
serviceProfileis set; the changelog documents the new option.Reviewed by Cursor Bugbot for commit 4eba08f. Bugbot is set up for automated code reviews on this repo. Configure here.