Repository navigation
feat(sentinel-api-service): add getFees, submitTransactions, cancel and batchStatus - #11272
Open
rarquevaux wants to merge 3 commits into
Open
rarquevaux wants to merge 3 commits into
rarquevaux wants to merge 3 commits into
Conversation
…nd batchStatus Add four smart-transaction endpoints exposed through messenger actions, gated on the chain's confirmations capability. Keep SentinelKind and SentinelMeta kind/wallet as deprecated.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
getFees,submitTransactions,cancelandbatchStatustoSentinelApiService, each exposed as aSentinelApiService:*messenger action, with response validation and tests. They are gated on the chain'sconfirmationscapability, not thesmartTransactionsliveness flag, which can flip between calls.SentinelKindandSentinelMeta.kind/walletare kept and marked@deprecated;SentinelMeta.featurealso accepts the newSentinelProductFeature.smart-transactions-controllerfrom direct Sentinel calls to this service (STX-976). No consumer calls these methods yet.References
Checklist
Note
Medium Risk
New paths submit and cancel signed transactions and interpret fee/status responses—incorrect validation or error handling could affect transaction flows once consumers migrate from direct Sentinel calls.
Overview
Adds four smart-transaction REST capabilities to
SentinelApiService—fee quotes (getFees), signed submission (submitTransactions, including optional cancel txs and metadata), cancellation (cancel), and multi-UUID status (batchStatus)—each wired as aSentinelApiService:*messenger action with superstruct validation and broad unit tests.All four call
/v1/networks/{chainId}/…, usestaleTime: 0(no caching), require the network registry’sconfirmationsflag (not the flakysmartTransactionsliveness bit), and on HTTP errors attach parsed JSON toHttpError.datavia a newreadJsonBodyhelper.Metadata typing moves forward additively: new
SentinelProductFeaturevalues onSentinelMeta.feature, plusSentinelKind/kind/walletmarked deprecated; batch status adds typed enums and a JSON fixture for response-shape tests.Reviewed by Cursor Bugbot for commit 01c0a84. Bugbot is set up for automated code reviews on this repo. Configure here.