Repository navigation
Conversation
Co-authored-by: Matt D. <geositta@users.noreply.github.com>
Co-authored-by: Matt D. <geositta@users.noreply.github.com>
Copilot stopped work on behalf of
geositta due to an error
November 3, 2026 04:42
Contributor
Author
|
@metamaskbot update-changelogs |
Contributor
|
✅ No changelog changes needed. |
Co-authored-by: Matt D. <geositta@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Hyperliquid unified-account balances were aggregated with native JavaScript numbers. Equivalent six-decimal
spot.total - spot.holdinputs could therefore emit different strings and differ by one atomic USDC unit after conversion.This change:
BigNumber;Focused regressions cover both reported operand pairs, fractional perps plus fractional spot collateral, final-only rounding across DEXs, a genuine one-micro-USDC change, streamed values, and the public Hyperliquid account-state path with isolated positions on main and HIP-3 DEXs.
Contract impact
USDC_DECIMALSis reusedConsumer compatibility
MetaMask Mobile at
eb837f5316dwas checked at the transaction-pay balance consumers. They already convertwithdrawableBalancewithBigNumber, so canonical six-decimal strings require no migration. No Extension checkout was available in this workspace; the published type and API shape are unchanged.References
Checklist
Note
Medium Risk
Changes how withdrawable and related balance strings are computed and formatted for Hyperliquid unified accounts, which can affect display and pay/withdraw validation even though the public shape is unchanged.
Reviewed by Cursor Bugbot for commit 036e491. Bugbot is set up for automated code reviews on this repo. Configure here.