Fix various disposable issues#2224
Merged
Merged
Conversation
This PR fixes a memory leak in Json Serializer and other small disposable issues
AArnott
added a commit
to AArnott/Nerdbank.MessagePack
that referenced
this pull request
Aug 22, 2025
Thank you @Bykiev who found and shared a fix for a similar bug in MessagePack-CSharp/MessagePack-CSharp#2224. Also mark `Sequence<T>` as sealed as a micro-optimization.
AArnott
approved these changes
Aug 22, 2025
This was referenced May 21, 2026
Open
This was referenced May 25, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in Json Serializer and other small disposable issues