Repository navigation
Fix UITextView content size ambiguous issue - #310
Conversation
|
|
nathantannar4
left a comment
There was a problem hiding this comment.
Looks like this is a better solution and it renders the correct result
nathantannar4
left a comment
There was a problem hiding this comment.
We will also need to change the update constraint method from
placeholderLabelConstraintSet?.width?.constant = -(placeholderLabelInsets.left + placeholderLabelInsets.right)
to
placeholderLabelConstraintSet?.right?.constant = -placeholderLabelInsets.right
|
@nathantannar4 I was going to ask if you didn't want to change your mind this time 🤣 That new label is too similar to the colors of existing labels 🤔 I also think labels on PRs are stupid. I never remember to add/remove them myself. I just created |
|
@nathantannar4 , I updated the changes. |
|
🔥 |
|
@zhongwuzw Can you just make a change log entry for this in the CHANGELOG.md ? These are non-breaking changes but we need to document them |
|
@nathantannar4 , I added the CHANGELOG entries. Forgive my little poor English .:cn::cn: |
No description provided.