Skip to content

Fix scroll to last item to take section inset into account #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hidoon wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix scroll to last item to take section inset into account #1832

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
beb1ae7
scrollToLastItem change
hidoon Feb 20, 2024
c5bf355
scrollToLastItem bug fix
hidoon Feb 20, 2024
40c5298
bug fix
hidoon Feb 20, 2024
f8ae2d4
remove self
hidoon Feb 20, 2024
8cede75
minor change
hidoon Feb 20, 2024
f848633
Merge branch 'main' into main
Kaspik Feb 21, 2024
83a8635
Merge branch 'main' into main
hidoon Feb 21, 2024
5c2a439
Merge branch 'main' into main
Kaspik May 17, 2024
c897d5f
Merge branch 'main' into main
Kaspik Jul 11, 2024
f03bffb
Merge branch 'main' into main
Kaspik Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Sources/Views/MessagesCollectionView.swift
View file
Open in desktop
Copy link
Copy Markdown

@fukemy fukemy Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think 3 times called scroll function is better

Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,24 @@ open class MessagesCollectionView: UICollectionView {

// NOTE: It's possible for small content size this wouldn't work - https://github.com/MessageKit/MessageKit/issues/725
public func scrollToLastItem(at pos: UICollectionView.ScrollPosition = .bottom, animated: Bool = true) {
guard let indexPath = indexPathForLastItem else { return }
guard let indexPath = indexPathForLastItem else { return }

scrollToItem(at: indexPath, at: pos, animated: animated)
// Store the current content offset
let originalOffset = contentOffset

// Scroll to the item without animation to get the desired offset
scrollToItem(at: indexPath, at: pos, animated: false)
let targetOffset = contentOffset

// Immediately reset the content offset to the original, without animation
setContentOffset(originalOffset, animated: false)

// Calculate the adjusted offset, considering the section insets
let sectionInsetBottom = (collectionViewLayout as? UICollectionViewFlowLayout)?.sectionInset.bottom ?? 0
let adjustedOffset = CGPoint(x: targetOffset.x, y: targetOffset.y + sectionInsetBottom)

// Scroll to the adjusted offset, with or without animation based on the method parameter
setContentOffset(adjustedOffset, animated: animated)
}

public func reloadDataAndKeepOffset() {
Expand Down