Skip to content

Fix hiding typing indicator crash. #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaspik merged 3 commits into from
Aug 23, 2023
Merged

Fix hiding typing indicator crash. #1804

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83d652e
Set typing indicator hidden inside performBatchUpdates to prevent flo…
Zandor300 Jul 10, 2023
21df63b
Merge branch 'main' into fix/typing-indicator-crash-v4
Kaspik Aug 23, 2023
6d3111d
Merge branch 'main' into fix/typing-indicator-crash-v4
Kaspik Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Set typing indicator hidden inside performBatchUpdates to prevent flo… 
…w layout from requesting message type from DataSource for typing indicator section.
  • Loading branch information
@Zandor300
Zandor300 committed Jul 10, 2023
commit 83d652e375faacb1946db386d31058bcb4421496
3 changes: 2 additions & 1 deletion Sources/Controllers/MessagesViewController+TypingIndicator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,15 @@ extension MessagesViewController {
}

let section = messagesCollectionView.numberOfSections
messagesCollectionView.setTypingIndicatorViewHidden(isHidden)

if animated {
messagesCollectionView.performBatchUpdates({ [weak self] in
self?.messagesCollectionView.setTypingIndicatorViewHidden(isHidden)
self?.performUpdatesForTypingIndicatorVisability(at: section)
updates?()
}, completion: completion)
} else {
messagesCollectionView.setTypingIndicatorViewHidden(isHidden)
performUpdatesForTypingIndicatorVisability(at: section)
updates?()
completion?(true)
Expand Down