Skip to content

Fix typing indicator in advanced example controller #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaspik merged 3 commits into from
Apr 30, 2023
Merged

Fix typing indicator in advanced example controller #1792

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
751f81a
Don't animate hiding typing indicator if also inserting a message
Kaspik Apr 30, 2023
c7fabf6
Changelog
Kaspik Apr 30, 2023
22d3963
Merge branch 'main' into fixAdvancedController
Kaspik Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Example/Sources/View Controllers/AdvancedExampleViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ final class AdvancedExampleViewController: ChatViewController {

MockSocket.shared.connect(with: [SampleData.shared.nathan, SampleData.shared.wu])
.onTypingStatus { [weak self] in
self?.setTypingIndicatorViewHidden(false)
self?.setTypingIndicatorViewHidden(false, animated: true)
}.onNewMessage { [weak self] message in
self?.setTypingIndicatorViewHidden(true, performUpdates: {
self?.setTypingIndicatorViewHidden(true, animated: false, performUpdates: {
self?.insertMessage(message)
})
}
Expand Down Expand Up @@ -190,9 +190,9 @@ final class AdvancedExampleViewController: ChatViewController {
return messageList[indexPath.section].user == messageList[indexPath.section + 1].user
}

func setTypingIndicatorViewHidden(_ isHidden: Bool, performUpdates updates: (() -> Void)? = nil) {
func setTypingIndicatorViewHidden(_ isHidden: Bool, animated: Bool, performUpdates updates: (() -> Void)? = nil) {
updateTitleView(title: "MessageKit", subtitle: isHidden ? "2 Online" : "Typing...")
setTypingIndicatorViewHidden(isHidden, animated: true, whilePerforming: updates) { [weak self] success in
setTypingIndicatorViewHidden(isHidden, animated: animated, whilePerforming: updates) { [weak self] success in
if success, self?.isLastSectionVisible() == true {
self?.messagesCollectionView.scrollToLastItem(animated: true)
}
Expand Down