Skip to content

Fix SwiftPM plugins #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinpucik merged 15 commits into from
Jul 31, 2022
Merged

Fix SwiftPM plugins #1732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ad308f0
fix: SwiftPM plugins
martinpucik Jul 30, 2022
cc5c4e3
fix: SwiftPM plugins
martinpucik Jul 30, 2022
d8aa261
fix: SwiftPM plugins
martinpucik Jul 30, 2022
a98cfe6
fix: SwiftPM plugins
martinpucik Jul 30, 2022
c098f91
fix: SwiftPM plugins
martinpucik Jul 30, 2022
1b11bd3
fix: SwiftPM plugins
martinpucik Jul 30, 2022
0e93c0c
fix: SwiftPM plugins
martinpucik Jul 30, 2022
7f6e5aa
fix: SwiftPM plugins
martinpucik Jul 31, 2022
a08ac70
fix: SwiftPM plugins
martinpucik Jul 31, 2022
f82555b
fix: SwiftPM plugins
martinpucik Jul 31, 2022
cd0bff2
fix: SwiftPM plugins
martinpucik Jul 31, 2022
2c72179
fix: SwiftPM plugins
martinpucik Jul 31, 2022
82128de
fix: SwiftPM plugins
martinpucik Jul 31, 2022
1c995d1
fix: SwiftPM plugins
martinpucik Jul 31, 2022
61d0739
fix: SwiftPM plugins
martinpucik Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: SwiftPM plugins 
Test failures reporting on CI
  • Loading branch information
@martinpucik
martinpucik committed Jul 31, 2022
commit a08ac7028a5498f28ab003a5ad10ddfa05568700
7 changes: 6 additions & 1 deletion Sources/Controllers/MessagesViewController+Keyboard.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ extension MessagesViewController {
keyboardManager.bind(inputAccessoryView: inputContainerView)
keyboardManager.bind(to: messagesCollectionView)




Comment thread
martinpucik marked this conversation as resolved.
Outdated
/// Observe didBeginEditing to scroll content to last item if necessary
NotificationCenter.default
.publisher(for: UITextView.textDidBeginEditingNotification)
Expand All @@ -42,7 +45,9 @@ extension MessagesViewController {
.delay(for: .milliseconds(200), scheduler: DispatchQueue.main)
.receive(on: DispatchQueue.main)
.sink { [weak self] notification in
self?.handleTextViewDidBeginEditing(notification)


Comment thread
martinpucik marked this conversation as resolved.
Outdated
self?.handleTextViewDidBeginEditing(notification)
}
.store(in: &disposeBag)

Expand Down
3 changes: 2 additions & 1 deletion Tests/MessageKitTests/Views Tests/AvatarViewTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ final class AvatarViewTests: XCTestCase {
XCTAssertEqual(avatarView.layer.cornerRadius, 15.0)
// For certain dynamic colors, need to compare cgColor in XCTest
// https://stackoverflow.com/questions/58065340/how-to-compare-two-uidynamicprovidercolor
XCTAssertEqual(avatarView.backgroundColor!.cgColor, UIColor.avatarViewBackground.cgColor)
// XCTAssertEqual(avatarView.backgroundColor!.cgColor, UIColor.avatarViewBackground.cgColor)
XCTAssertEqual(avatarView.backgroundColor!.cgColor, UIColor.red)
}

func testWithImage() {
Expand Down