Skip to content

Move messageInputBar from inputAccessoryView to a subview in MessagesViewController #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaspik merged 15 commits into from
May 5, 2022
Merged

Move messageInputBar from inputAccessoryView to a subview in MessagesViewController #1704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0709350
refactor: InpuBar as subview instead of accessoryView
martinpucik Apr 29, 2022
dbbf45d
refactor: InpuBar as subview instead of accessoryView
martinpucik May 3, 2022
156fd97
Merge branch '4.0.0' into input-bar-as-subview
martinpucik May 3, 2022
659137a
refactor: InpuBar as subview instead of accessoryView
martinpucik May 3, 2022
2a59239
Merge branch '4.0.0' into input-bar-as-subview
martinpucik May 3, 2022
1bdf04f
Merge branch '4.0.0' into input-bar-as-subview
martinpucik May 3, 2022
4ab430c
refactor: InpuBar as subview instead of accessoryView
martinpucik May 4, 2022
51157f3
refactor: InpuBar as subview instead of accessoryView
martinpucik May 4, 2022
859e9c2
refactor: InpuBar as subview instead of accessoryView
martinpucik May 4, 2022
dee9a22
refactor: InpuBar as subview instead of accessoryView
martinpucik May 4, 2022
27243aa
refactor: InpuBar as subview instead of accessoryView
martinpucik May 4, 2022
9c0e72a
Merge branch '4.0.0' into input-bar-as-subview
martinpucik May 5, 2022
408d041
Update CHANGELOG.md
Kaspik May 5, 2022
aef7ecc
refactor: InpuBar as subview instead of accessoryView
martinpucik May 5, 2022
cb81afd
Merge branch 'input-bar-as-subview' of github.com:MessageKit/MessageK…
martinpucik May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: InpuBar as subview instead of accessoryView 
Updated InputBarAccessoryView version to 6.0.0
  • Loading branch information
@martinpucik
martinpucik committed May 5, 2022
commit aef7eccaba698737354a32bf422f1e04cc91fbba
6 changes: 4 additions & 2 deletions Example/Sources/View Controllers/ChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ class ChatViewController: MessagesViewController, MessagesDataSource {

override func viewDidLoad() {
super.viewDidLoad()

navigationItem.largeTitleDisplayMode = .never
navigationItem.title = "MessageKit"

configureMessageCollectionView()
configureMessageInputBar()
loadFirstMessages()
title = "MessageKit"

}

override func viewDidAppear(_ animated: Bool) {
Expand Down
1 change: 1 addition & 0 deletions Example/Sources/View Controllers/LaunchViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ final internal class LaunchViewController: UITableViewController {
title = "MessageKit"
navigationItem.backBarButtonItem = UIBarButtonItem(title: "", style: .plain, target: nil, action: nil)
navigationController?.navigationBar.prefersLargeTitles = true
navigationController?.navigationBar.tintColor = .primaryColor
tableView.register(UITableViewCell.self, forCellReuseIdentifier: "cell")
tableView.tableFooterView = UIView()
}
Expand Down
3 changes: 1 addition & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ let package = Package(
.library(name: "MessageKit", targets: ["MessageKit"]),
],
dependencies: [
// .package(url: "https://github.com/nathantannar4/InputBarAccessoryView", .upToNextMajor(from: "5.5.0"))
.package(url: "https://github.com/nathantannar4/InputBarAccessoryView", .branch("master"))
.package(url: "https://github.com/nathantannar4/InputBarAccessoryView", .upToNextMajor(from: "6.0.0"))
],
targets: [
.target(
Expand Down
1 change: 0 additions & 1 deletion Sources/Controllers/MessagesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ open class MessagesViewController: UIViewController, UICollectionViewDelegateFlo
addMenuControllerObservers()
/// Layout input container view and update messagesCollectionViewInsets
view.layoutIfNeeded()
updateMessageCollectionViewBottomInset()
}

open override func viewSafeAreaInsetsDidChange() {
Expand Down