Skip to content

FIxed slack link in CONTRIBUTING.md resolved #1395 - #1396

Merged
kinoroy merged 2 commits into
MessageKit:developmentfrom
artemas-radik:master
Jun 29, 2020
Merged

FIxed slack link in CONTRIBUTING.md resolved #1395#1396
kinoroy merged 2 commits into
MessageKit:developmentfrom
artemas-radik:master

Conversation

@artemas-radik

@artemas-radik artemas-radik commented Jun 28, 2020

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Fixes the broken slack link in CONTRIBUTING.md.

Does this close any currently open issues?

Yes, closes #1395

Any relevant logs, error output, etc?

None.

Any other comments?

None.

Where has this been tested?

Devices/Simulators: …
N/A
iOS Version: …
N/A
Swift Version: …
N/A
MessageKit Version: …
N/A

kinoroy
kinoroy approved these changes Jun 29, 2020
View reviewed changes

@kinoroy kinoroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @ajradik ! 🤗

@kinoroy
kinoroy changed the base branch from master to development June 29, 2020 01:24
@kinoroy

kinoroy commented Jun 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@ajradik Do you mind just rebasing this off of development before merging? There's a bug with Danger failing on forked branches so we have to merge forks to dev right now. Then all checks should pass 👍 Scratch that, I needed to update development from master anyways, so I'll just do that in a separate PR, and update your branch.

@kinoroy
kinoroy merged commit 2572e3c into MessageKit:development Jun 29, 2020
@SD10

SD10 commented Jun 29, 2020

Copy link
Copy Markdown
Member

Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃

kinoroy added a commit that referenced this pull request Jun 29, 2020
@kinoroy
Merge pull request #1396 from ajradik/master
33e4763 
FIxed slack link in CONTRIBUTING.md resolved #1395
@kinoroy kinoroy mentioned this pull request Jun 29, 2020
Closed
@erwanmace

erwanmace commented Jan 21, 2023

Copy link
Copy Markdown
Contributor

The slack link is invalid. Can you guys repost?

@kinoroy

kinoroy commented Jan 21, 2023

Copy link
Copy Markdown
Member

@erwanmace here's an updated invite: https://join.slack.com/t/messagekit/shared_invite/zt-1nmj5q4c6-LTQJvqoGPmBdnAOOnYFrUQ

@monstermac77 monstermac77 mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinoroy kinoroy kinoroy approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md "You can get in touch with the MessageKit core team directly by joining our open Slack community channel" link broken

4 participants

@artemas-radik @kinoroy @SD10 @erwanmace