Repository navigation
Remove CircleCI badge from README.md #trivial - #1372
Merged
Merged
Conversation
Added badges for Github Actions
Contributor
Author
Github Actions bages link to action list
Added Danger badge
Member
|
I think right now we only run CI for PRs so would this only show the status of the last PR merged (whether or not that went to master or dev or some other branch)? Should we run build/test also on commits to master or dev so we can display the badge for those branches instead? |
Contributor
Author
|
@kinoroy I think there is an option to filter the badge for a specific branch. I’ll check. |
Member
|
You're right, actually it says here that the badges show the state of the master branch by default. So I guess its just showing the latest ran PR that merged to the master branch which is probably good enough since we should all be using PRs to commit to master. |
kinoroy
approved these changes
Jun 2, 2020
austinwright
reviewed
Jun 2, 2020
Rename Danger action
Rename Tests action
Rename Framework build action
Rename Build Example app action
Use new action names for badges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this implement/fix? Explain your changes.
Removes no longer used CircleCI status bagge
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Any other comments?
N/A