Skip to content

Remove CircleCI badge from README.md #trivial - #1372

Merged
martinpucik merged 9 commits into
masterfrom
circleci_badge_readme
Jun 3, 2020
Merged

martinpucik merged 9 commits into
masterfrom
circleci_badge_readme

Conversation

@martinpucik

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Removes no longer used CircleCI status bagge

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

Any other comments?

N/A

Added badges for Github Actions
@martinpucik

Copy link
Copy Markdown
Contributor Author

Badges with status from Github Actions
Screenshot 2020-06-02 at 18 48 54

Github Actions bages link to action list
Added Danger badge
@kinoroy

kinoroy commented Jun 2, 2020

Copy link
Copy Markdown
Member

I think right now we only run CI for PRs so would this only show the status of the last PR merged (whether or not that went to master or dev or some other branch)? Should we run build/test also on commits to master or dev so we can display the badge for those branches instead?

@martinpucik

Copy link
Copy Markdown
Contributor Author

@kinoroy I think there is an option to filter the badge for a specific branch. I’ll check.
That should be enough tho and we wouldn’t need another set of actions to run on master pushes

@kinoroy

kinoroy commented Jun 2, 2020

Copy link
Copy Markdown
Member

You're right, actually it says here that the badges show the state of the master branch by default. So I guess its just showing the latest ran PR that merged to the master branch which is probably good enough since we should all be using PRs to commit to master.

Comment thread README.md Outdated
Rename Danger action
Rename Tests action
Rename Framework build action
Rename Build Example app action
Use new action names for badges
@martinpucik
martinpucik merged commit 4d4306f into master Jun 3, 2020
@martinpucik
martinpucik deleted the circleci_badge_readme branch June 3, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants