Skip to content

Update README.md - #1333

Merged
kinoroy merged 3 commits into
MessageKit:developmentfrom
alexBotteri:patch-1
May 14, 2020
Merged

Update README.md#1333
kinoroy merged 3 commits into
MessageKit:developmentfrom
alexBotteri:patch-1

Conversation

@alexBotteri

@alexBotteri alexBotteri commented Apr 20, 2020

Copy link
Copy Markdown

What does this implement/fix? Explain your changes.

added Ring4 in the projects list using MessageKit

Does this close any currently open issues?

…

Any relevant logs, error output, etc?

Any other comments?

…

Where has this been tested?

Devices/Simulators: …

iOS Version: …

Swift Version: …

MessageKit Version: …

@Kaspik
Kaspik changed the base branch from master to development April 20, 2020 06:34
@Kaspik
Kaspik changed the base branch from development to master April 20, 2020 06:35
@Kaspik

Kaspik commented Apr 20, 2020

Copy link
Copy Markdown
Member

This needs to go from development branch against development branch.

@SD10

SD10 commented Apr 22, 2020

Copy link
Copy Markdown
Member

This should be fine to just go into master directly 👍

@Kaspik

Kaspik commented Apr 23, 2020

Copy link
Copy Markdown
Member

@SD10 The problem is that Danger has bug and is not working from forks - so we wanted to restrict that no fork goes to master...

@kinoroy
kinoroy changed the base branch from master to development May 14, 2020 06:32
@codecov

codecov Bot commented May 14, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1333 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1333   +/-   ##
============================================
  Coverage        64.75%   64.75%           
============================================
  Files               68       68           
  Lines             3305     3305           
============================================
  Hits              2140     2140           
  Misses            1165     1165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee2dee...fe37378. Read the comment docs.

@kinoroy

kinoroy commented May 14, 2020

Copy link
Copy Markdown
Member

Going to merge to dev due to the Danger issue.

@kinoroy
kinoroy merged commit afde0b1 into MessageKit:development May 14, 2020
@SD10

SD10 commented May 14, 2020

Copy link
Copy Markdown
Member

Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kaspik Kaspik Kaspik approved these changes
@SD10 SD10 SD10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexBotteri @Kaspik @SD10 @kinoroy