Skip to content

documentation: Loading remote image messages in Example project - #1294

Merged
Kaspik merged 4 commits into
MessageKit:developmentfrom
martinpucik:documentation/remote_image_example
Mar 23, 2020
Merged

Kaspik merged 4 commits into
MessageKit:developmentfrom
martinpucik:documentation/remote_image_example

Conversation

@martinpucik

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

  • 👻 This PR adds option to use photo messages with remote URL in Example project
  • Adding refresh control to collection view with iOS11 and higher style

Does this close any currently open issues?

Any relevant logs, error output, etc?

  • N/A

Any other comments?

  • N/A

Where has this been tested?

iOS Version: 13.3

Swift Version: 5.1

MessageKit Version: 3.1.0

@Kaspik Kaspik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Martin! 🚀

@Kaspik

Kaspik commented Mar 20, 2020

Copy link
Copy Markdown
Member

Note: It needs change in Changelog or #trivial hashtag - I think this should go to changelog. :)

@Kaspik

Kaspik commented Mar 20, 2020

Copy link
Copy Markdown
Member

hmmm, Danger has bug for forked repos: danger/danger#1103
We will need to disable that for now probably. 😢

@Kaspik
Kaspik merged commit 6733905 into MessageKit:development Mar 23, 2020
@martinpucik
martinpucik deleted the documentation/remote_image_example branch March 23, 2020 09:27
@Kaspik Kaspik mentioned this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants