Skip to content

Update Circle CI PR tests to include cache for pods - #1256

Merged
Kaspik merged 7 commits into
MessageKit:developmentfrom
classdojo:circleCIUpdates
Feb 28, 2020
Merged

Kaspik merged 7 commits into
MessageKit:developmentfrom
classdojo:circleCIUpdates

Conversation

@Kaspik

@Kaspik Kaspik commented Feb 26, 2020

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Change example build to use cache for pods, without fetching specs.

Does this close any currently open issues?

No

@austinwright austinwright self-assigned this Feb 26, 2020
Comment thread .circleci/config.yml

build_tests:
macos:
xcode: 11.3.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: can this be set using an opportunistic operator so that we get Xcode bugfix versions automatically?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to keep it specific as you need to update the simulator usually too.

Comment thread .circleci/config.yml
Comment thread .circleci/config.yml
Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated
Comment thread MessageKit.podspec
s.source = { :git => 'https://github.com/MessageKit/MessageKit.git', :tag => s.version }
s.source_files = 'Sources/**/*.swift'

s.pod_target_xcconfig = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you speak to these two removals and why they are not needed anymore?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.requires_arc is true by default - not necessary then.
s.pod_target_xcconfig SWIFT_VERSIONis legacy thing that was replaced bys.swift_version` that we already have. More updates coming! :)

@austinwright

austinwright commented Feb 28, 2020 •

Copy link
Copy Markdown
Contributor

Also, PR needs a change-log entry (right? 😅)
Changelog entries not needed for CI changes which don't directly affect the Framework end-user

@Kaspik
Kaspik merged commit 4b4dd27 into MessageKit:development Feb 28, 2020
@Kaspik
Kaspik deleted the circleCIUpdates branch February 28, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants